Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

line breaks and formula formatting #85

Closed
wants to merge 2 commits into from
Closed

line breaks and formula formatting #85

wants to merge 2 commits into from

Conversation

dericed
Copy link
Contributor

@dericed dericed commented Jan 3, 2018

No description provided.

JeromeMartinez
JeromeMartinez approved these changes Jan 4, 2018
View reviewed changes
Copy link
Contributor

@JeromeMartinez JeromeMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally prefer line breaks inside paragraphs so double space in Markdown but if the goal is to remove line breaks inside paragraphs it is fine.

initial_state_delta display is a lot better in HTML (PDF not tested)

@dericed
Copy link
Contributor Author

dericed commented Jan 9, 2018

I rebased this pr with the updated master branch. Please re-review.

@michaelni
Copy link
Member

Iam gettimng these warnings: with this locally merged
WARNING: artwork outdented 3 characters to avoid overrunning right margin around input line 1381)
WARNING: Output line (from source around line 1381) is 82 characters; longer than 72. Excess characters: ' ] ) & 255':
'initial_state[ i ][ j ][ k ] = ( pred + initial_state_delta[ i ][ j ][ k ] ) & 255'

@dericed
Copy link
Contributor Author

dericed commented Jan 10, 2018

@michaelni I updated to add a line break in the middle of that equation. We already use this practice in a few other places such as the equations in the 'State transition table' section.

@dericed
Copy link
Contributor Author

dericed commented Jan 11, 2018

bump :)

@michaelni michaelni closed this in 67efbaa Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeromeMartinez JeromeMartinez JeromeMartinez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dericed @michaelni @JeromeMartinez